Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Use OBSBasic::Get() in all places #11159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Aug 20, 2024

Description

This reduces duplicated code when getting the OBSBasic context.

Motivation and Context

I don't like duplicated code

How Has This Been Tested?

Made sure everything worked as expected.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Aug 20, 2024
@Warchamp7 Warchamp7 self-assigned this Oct 7, 2024
@cg2121 cg2121 force-pushed the obsbasic-get-everywhere branch 2 times, most recently from f622acc to 573c700 Compare November 15, 2024 12:43
This reduces duplicated code when getting the OBSBasic context.
Since we are converting between qobjects, it is safer to use
qobject_cast than reinterpret_cast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

3 participants